GCEL / CARDAMOM

The CARbon DAta MOdel FraMework. Computer software that retrieves terrestrial carbon (C) cycle variables by combining C cycle observations with a mass balance model.
GNU General Public License v3.0
2 stars 0 forks source link

Merging in changes associated with addition of dalec.29 (NEOMI project) #33

Closed DTMilodowski closed 1 year ago

DTMilodowski commented 1 year ago

This wide-reaching set of changes is associated with: (1) new model version developed for the NEOMI project, dalec.29. This is almost identical to dalec.4., but with a variable minLWP parameter, allowing for the expression of a more diverse plant hydraulic traits. (2) assimilation of leaf litter (currently available for dalec.29 and dalec.4.) following the "mean flux, uncertainty, lag" formulation consistent with mortality and growth fluxes

DTMilodowski commented 1 year ago

@lsmallma Hi Luke, I am ready to roll in dalec.29 into the main dev branch. I've accounted for the code structure changes made in the past month, so should otherwise be consistent with our previous discussions.

lsmallma commented 1 year ago

HI David,

Sounds like you have been busy. Thanks for accounting for the recent changes I’ve been making.

I can’t check the code changes at the moment. My phone has just died so I can’t access Github (2-factor authorisation via phone…)

I’m happy for you to progress regardless.

Thanks for keeping DALEC.4. up to date in this too.

Luke

Dr T. Luke Smallman Research Fellow (NCEO)

School of GeoSciences Crew Building University of Edinburgh EH9 3JN, UK Edinburgh

On 9 Oct 2023, at 12:07, David Milodowski @.***> wrote:

This email was sent to you by someone outside the University. You should only click on links or attachments if you are certain that the email is genuine and the content is safe.

@lsmallmahttps://github.com/lsmallma Hi Luke, I am ready to roll in dalec.29 into the main dev branch. I've accounted for the code structure changes made in the past month, so should otherwise be consistent with our previous discussions.

— Reply to this email directly, view it on GitHubhttps://github.com/GCEL/CARDAMOM/pull/33#issuecomment-1752801605, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AGDTODMBMPOZQ5RBTMUDFV3X6PLHHAVCNFSM6AAAAAA5YTOVRSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJSHAYDCNRQGU. You are receiving this because you were mentioned.Message ID: @.***>

The University of Edinburgh is a charitable body, registered in Scotland, with registration number SC005336. Is e buidheann carthannais a th’ ann an Oilthigh Dhùn Èideann, clàraichte an Alba, àireamh clàraidh SC005336.