SaeedHatefi
commented
1 year ago - [x] Reviewed function(s): MasterConfigFile, setDefaults, cleanInput, main, getFext, RunSim, RunTests, write2vtk_quasistatic, RunCantileverBeam, CantileverBeam, CantileverBeam_check
- [x] Ran test case(s): RunSim, RunTests, RunCantileverBeam
- Purpose of the code: to add the option of incremental analysis of the problems by defining timestep loops
- Notes on implementation: I tested the code by running RunSim function. Also, I tested the code by runing RunTests file and specifically RunCantileverBeam. It looks good for this case. Also, I have checked resulted .vtk files and they are correct. However, I would suggest adjusting few things on the code:
- It seems that the file main_static in Main folder is unused. So, it can be deleted.
- I would suggest merging the 'develop' branch into the 'quasi-time' again so that the new added tests (e.g. Q8 elements and bimaterial tests) are included;
- Consider that Dirichlet boundary conditions can also be a function of time because probabely in the fututre we want to solve nonlinear problems in Force control or Displacement control methods. If you think that we will address this issure in other next branches you can ignore this comment.
- It seems that the code is also working for the case that start time is a value greater than zero. I would suggest double-checking this option in the code.
- Notes on legibility and style: N/A
- Notes on maintainability: N/A
- Suggested test cases:
- I would suggest considereing the case in which Dirichlet boundary condition is a function of time.
b3gee
What?
Add the feature to have quasi-time dependent loadings / solve the problem in load steps.
Why?
To create a basis for including time-dependent problems, material models, and non-linear problems.
How?
Introduce time controls and create a timestep loop in the solver.
Testing?
The Cantilever Beam test has been updated to have a sinusoidal loading in quasi-time. The displacements at the end of the bar are saved and compared against the Euler beam solution scaled to the same loading.
Anything Else?
The default analysis type has been set to quasi-static. If no time controls are specified, the default assumes a static analysis which it performs with a single timestep.