search

GCTC-NTGC / design-gc-digital-talent

GC Digital Talent design issues
0 stars 0 forks source link

⌨ Investigate found Automated WCAG conformance issues #21

Closed RM-1978 closed 8 months ago

RM-1978 commented 1 year ago

⌨ Accessibility conformance verification

An Automated Review of the platform using SiteImprove revealed the WCAG 2 conformance errors in the screenshot below.

📸 Screenshot

Image

WCAG 2.1 Criteria

List of WCAG A and AA criteria to be confirmed. New issues will be created depending on the location of the errors.

🦋 Expected Behaviour

✅ Acceptance Criteria

A set of assumptions which, when tested, verify that the issue was addressed.

RM-1978 commented 1 year ago

@gobyrne and @esizer Here are the results of the SiteImporve tests. I think that we could look at the ARIA issues with @esizer and @substrae.

We will need to sit down to discuss the design system results with Lauren and the design team as most of the issues seem to be on the design side :( We should also chat about the AAA issues and whether or not we want to future proof the design for WCAG 2.2 and WCAG 3.

📸 Screenshot

Image

You will see the column titled ‘conformance’ where we list the issue based on conformance to WCAG 2.1. In summary:

JoshBeveridge commented 1 year ago

As Lee mentioned, the AAA stuff should be broken away for a later conversation. We don't have the resources to process them right now. Meeting AAA contrast requirements are impossible with our current palette, so we'd end up having to rebrand the whole product. Altering something as fundamental as line-height requires a rework of every single component in our library. Increasing line height too much is arguably bad for legibility, and our line heights also vary depending on the element for layout purposes, meaning there are likely false positives here. Editing to say that our line height for paragraph text already meets this requirement, as it's set at 1.5.

The two we should prioritize fixing, from what I can tell, are the ARIA attribute error and the form element contrast problems. We'll need to know specifics about each:

JoshBeveridge commented 1 year ago

I also noticed that in the original report summary image there are 16 A level errors/warnings, but they don't seem to be present in the more detailed report screenshot. Any idea about what they were or where they went?

RM-1978 commented 11 months ago

@substrae Thanks for your comments!

Upon further investigation and a rescan, SiteImprove has confirmed that the overall automated score for GC Digital Talent is: 94.4 / 100.
The score to be AA compliant from an automated testing perspective for this site is 96.7 / 100. The nature of the issues they found were based on conformance to WCAG 2.1. They include:

The good news is that the rescan (on Dec. 6, 2023) also confirmed that there are no level A issues were detected on GC Talent.

Brinda and I have also invited them in to demo their tool for us on January 19th to better understand a bit more about it and how they arrived at these results :)

JoshBeveridge commented 11 months ago

Great, that sounds a lot more accurate than the original results!

gobyrne commented 8 months ago

Closing. We can re-open if we get actionable details on the failings. (aka we can see the report)