GCTC-NTGC / design-gc-digital-talent

GC Digital Talent design issues
0 stars 0 forks source link

✨ Equity Statement Stub #45

Open petertgiles opened 11 months ago

petertgiles commented 11 months ago

✨ Feature

A new equity statement page is being designed.

🕵️ Details

Add any additional details that could assist with the development of the new feature.

🎨 Design File

Include a link to the design file (if it exists).

🧑‍🎨 Designer

Include the author of the linked design file's name (or even better, their @githubUsername) for future reference.

📸 Screenshot

image

🙋‍♀️ Proposed Implementation

(optional) Do you have a proposed implementation?

🌎 Localization

(optional) Provide any new copy along with translations available.

✅ Acceptance Criteria

A set of assumptions which, when tested, verify that the feature was properly implemented.

mnigh commented 11 months ago

📸 Screenshot

image

Is there a reason why the questions are in quotes? We don't do this elsewhere, for example:

Screenshot

Screen Shot 2023-12-18 at 16 40 36

JoshBeveridge commented 11 months ago

@mnigh For anything written in the user's perspective we tend to lean towards quotations to emphasize that we're quoting a "user". This has been used elsewhere (see the equity statements) and was likely missed in the FAQ sections you've referenced here.

mnigh commented 7 months ago

@mnigh For anything written in the user's perspective we tend to lean towards quotations to emphasize that we're quoting a "user". This has been used elsewhere (see the equity statements) and was likely missed in the FAQ sections you've referenced here.

I disagree with this style for emphasis as it confuses what most users understand when quotation marks are used (to reference something said or written by another person), but in any case, how is "Who can apply to this recruitment process?" written from a user's perspective? The question doesn't include any subject.

Screenshot

Screen Shot 2024-04-15 at 16 55 17
JoshBeveridge commented 7 months ago

This whole section is formatted as questions the user might ask along with answers to those questions.