search

GCTC-NTGC / gc-accessibility-passport

https://gc-accessibility-passport-psi.vercel.app
1 stars 0 forks source link

Update EN strings and FR equivalent strings #174

Closed mnigh closed 2 years ago

mnigh commented 2 years ago

Resolves #172.

Notes

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
gc-accessibility-passport ✅ Ready (Inspect) Visit Preview Jun 8, 2022 at 4:02PM (UTC)
yonikid15 commented 2 years ago

There's still a few files where the translations aren't showing up.

manage-permissions.tsx image

passport.tsx image

....Actually, I'm seeing missing translations on pretty much every page 😢. Does changing the source text change the id in the en.json file?

mnigh commented 2 years ago

There's still a few files where the translations aren't showing up.

Indeed, good catch @yonikid15. There are 67 missing string translations for FR and I will need to manually find each one.