GCX-HCI / ThirtyInch

a MVP library for Android favoring a stateful Presenter
Apache License 2.0
1.03k stars 101 forks source link

Add project codestyles #123

Closed ghost closed 6 years ago

ghost commented 6 years ago

This will fix #122 As discussed in #122 this pull request adds project specific code styles based on the grandcentrix android code styles (https://github.com/grandcentrix/androidcodestyle) to the project.

passsy commented 6 years ago

Not sure if we should convert all sources within this PR or not 🤔

ghost commented 6 years ago

@passsy Good point. Was thinking about that as well. 🤔 But I wanted to wait for your and @StefMa opinions before actually applying those styles.

StefMa commented 6 years ago

Hmm.. Since we don't have that much PR I would suggest to do it. 👍

On Oct 2, 2017 12:37 PM, "rberghegger" notifications@github.com wrote:

@passsy https://github.com/passsy Good point. Was thinking about that as well. 🤔 But I wanted to wait for your and @StefMa https://github.com/stefma opinions before actually applying those styles.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/grandcentrix/ThirtyInch/pull/123#issuecomment-333498816, or mute the thread https://github.com/notifications/unsubscribe-auth/AJwYe73W_Edmbo_6khBEr8UL1pk25O7xks5soLzpgaJpZM4Pqc0S .

passsy commented 6 years ago

true, just do it. If there are conflicts we can solve them by applying the code style as well

ghost commented 6 years ago

Done. I've applied the new project codestyle to every module individually. Additionally I've added CONTRIBUTING.md which contains a few informations regarding the codestyle.

StefMa commented 6 years ago

I would suggest to remove the TK from the contribution file. Also start with a single # and use two for code style... 👍 rest lgtm