Closed ghost closed 7 years ago
Not sure if we should convert all sources within this PR or not 🤔
@passsy Good point. Was thinking about that as well. 🤔 But I wanted to wait for your and @StefMa opinions before actually applying those styles.
Hmm.. Since we don't have that much PR I would suggest to do it. 👍
On Oct 2, 2017 12:37 PM, "rberghegger" notifications@github.com wrote:
@passsy https://github.com/passsy Good point. Was thinking about that as well. 🤔 But I wanted to wait for your and @StefMa https://github.com/stefma opinions before actually applying those styles.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/grandcentrix/ThirtyInch/pull/123#issuecomment-333498816, or mute the thread https://github.com/notifications/unsubscribe-auth/AJwYe73W_Edmbo_6khBEr8UL1pk25O7xks5soLzpgaJpZM4Pqc0S .
true, just do it. If there are conflicts we can solve them by applying the code style as well
Done. I've applied the new project codestyle to every module individually. Additionally I've added CONTRIBUTING.md
which contains a few informations regarding the codestyle.
I would suggest to remove the TK from the contribution file. Also start with a single # and use two for code style... 👍 rest lgtm
This will fix #122 As discussed in #122 this pull request adds project specific code styles based on the grandcentrix android code styles (https://github.com/grandcentrix/androidcodestyle) to the project.