GCX-HCI / ThirtyInch

a MVP library for Android favoring a stateful Presenter
Apache License 2.0
1.03k stars 101 forks source link

Update to gradle plugin 3.0 #135

Closed StefMa closed 6 years ago

StefMa commented 6 years ago

With that change we can think about our dependencies again.

Do we want to "bundle" the dependencies with our libraries or not? Which means, do we want to use api or implementation? If we decided we use implementation we can also think about to use compileOnly for "all", right? Since we don't really need a special version or something. Our implementations are very "basic" and I think all future releases of our dependencies will support our implementation...

What do you think?

*Note:* While upgrading I had some issues with jacoco. So i declared the jacoco version and added the test coverage in the sample. jacoco closure is depcreated . We have to add it to the classpath...

StefMa commented 6 years ago

We decided to use #136