GCX-HCI / ThirtyInch

a MVP library for Android favoring a stateful Presenter
Apache License 2.0
1.03k stars 101 forks source link

Update to gradle 3.0 #136

Closed passsy closed 6 years ago

StefMa commented 6 years ago

Blocked by https://github.com/novoda/bintray-release/issues/149

Do not merge since bintray-release can't handle this and we were unable to make a release with that :)

passsy commented 6 years ago

@StefMa wanny try https://github.com/novoda/bintray-release/releases/tag/0.8.0?

StefMa commented 6 years ago

For testing I've updloaded it to my personal bintray account. Use

repositories {
    maven { url "https://dl.bintray.com/stefma/maven" }
}

dependencies {
    def thirtyinchVersion = '0.8.6-TEST'
    implementation "net.grandcentrix.thirtyinch:thirtyinch:$thirtyinchVersion"
    implementation "net.grandcentrix.thirtyinch:thirtyinch-rx2:$thirtyinchVersion"
    implementation "net.grandcentrix.thirtyinch:thirtyinch-logginginterceptor:$thirtyinchVersion"
}
StefMa commented 6 years ago

Hmm somehow the Rx2 module wasn't uploaded successfully 🤔 Strange. -> https://dl.bintray.com/stefma/maven/net/grandcentrix/thirtyinch/thirtyinch-rx2/0.8.6-TEST/

StefMa commented 6 years ago

I have upload it again and now it works... Strange 😱

StefMa commented 6 years ago

Seems to be a "one time issue". No issues with https://dl.bintray.com/stefma/maven/net/grandcentrix/thirtyinch/thirtyinch-rx2/0.8.7-TEST/ so far 👍

StefMa commented 6 years ago

Checked ./gradlew app:dependencies. Seems that everything got packed correctly: bildschirmfoto 2017-11-30 um 16 32 13 ThirtyInch brings no dependencies with in.. But Rx2-module brings Rx-Java2 but updated it internally to 2.1.5 (because the app themself depends on version 2.1.5) 🎉

Seems that everything is correct 👍

passsy commented 6 years ago

Verified, all dependencies can be resolved correctly. I was quite surprised our core module has no external dependencies 😮