GCX-HCI / ThirtyInch

a MVP library for Android favoring a stateful Presenter
Apache License 2.0
1.03k stars 101 forks source link

[Discussion] Should manageViewDisposable() throw an exception #147

Open Syex opened 6 years ago

Syex commented 6 years ago

Currently manageViewDisposable() throws an exception when we're adding a Disposable while no view is attached.

I was thinking if this is preferable to just disposing, as we want that Disposable to dispose when view detaches. No view is attached so we could simply dispose it. We could also think of adding a configuration parameter for this.