GCX-HCI / ThirtyInch

a MVP library for Android favoring a stateful Presenter
Apache License 2.0
1.03k stars 101 forks source link

Allow usage with AndroidX #153

Closed passsy closed 6 years ago

passsy commented 6 years ago

AndroidX doesn’t allow calling of package private methods, like Fragment#isInBackstack. As a temporary workaround we can get the same information via the public dump() method.

The performance is fine and in my test scenarios always below <2ms.

fixes #149

How to test

Testing is harder this time.

  1. I released this PR to mavenLocal()
  2. I cloned Ti again, migrated the sample to AndroidX with Android Studio 3.2 beta4, disabled all other modules and included the new dependencies. (I pushed it here)

Converting Ti completely to AndroidX is no alternative. We want to test with android.enableJetifier.