search

GCX-HCI / ThirtyInch

a MVP library for Android favoring a stateful Presenter
Apache License 2.0
1.03k stars 101 forks source link

Migrate to AndroidX #166

Closed rehlma closed 5 years ago

passsy commented 6 years ago

Merge after #168

StefMa commented 6 years ago

Fix the conflicts 👆 :) Probably just imports conflicts...

passsy commented 6 years ago

It doesn't work with old AppCompat projects.

I don't want to leave people behind so short after the final AndroidX release. I recommend to finalize this migration in January 2019.

passsy commented 6 years ago

@rehlma you could update the deps and sdk in the meantime

StefMa commented 6 years ago

What about to release (at least for the next version) a -compat version of TI? Which uses the AppCompat instead of X? Or will this too much overhead?

rehlma commented 6 years ago

I've tried that but that would mean that we have to duplicate almost every module because every module has a dependency to the Ti "core".

It might be best if we ship a version including the fix, which passsy is working on, and do the AndroidX stuff then.
All users with non AndroidX Projects can use that version and all other the newest AndroidX version.

lukaszkalnik commented 5 years ago

Is there a plan to merge it? The conflicts seem easy to resolve.

rehlma commented 5 years ago

I'll have a look again and try to re-add the @nonnull annotation again because it was a bug I think.

lukaszkalnik commented 5 years ago

You need to add androidx.annotation:annotation as testCompileOnly as well to make it available to the test source code.

rehlma commented 5 years ago

You need to add androidx.annotation:annotation as testCompileOnly as well to make it available to the test source code.

That's the solution 🎉 👍

StefMa commented 5 years ago

Travis is fixed; build failed with some D8 issues...

StefMa commented 5 years ago

I'll close this for now in favor of #197 (and following PRs)