search

GCX-HCI / ThirtyInch

a MVP library for Android favoring a stateful Presenter
Apache License 2.0
1.03k stars 101 forks source link

Convert thirtyinch module tests to Kotlin #174

Closed lukaszkalnik closed 5 years ago

lukaszkalnik commented 5 years ago

Adds Kotlin support to thirtyinch module tests. As a start, converts TiTestPresenterTest and TestPresenterExampleTest to Kotlin and MockK.

lukaszkalnik commented 5 years ago

The build before updating the gradle plugin was failing because of not finishing download of gradle plugin. ~Maybe~ it was just a temporary issue with the repo though... ~Now after updating the plugin the licenses on Travis need to be accepted...~

bildschirmfoto 2018-12-24 um 22 12 17
StefMa commented 5 years ago

You have to update the travis.yml file too

lukaszkalnik commented 5 years ago

Ok, I think we can do it in a separate PR.

lukaszkalnik commented 5 years ago

As discussed in a conversation with @passsy the library is pretty stable right now and at this moment there is no need to convert the source code (especially tests) to Kotlin. Instead of reviewing this and related PRs we can direct our efforts to more valuable goals. So I'm closing it and all related PRs for now