search

GCX-HCI / ThirtyInch

a MVP library for Android favoring a stateful Presenter
Apache License 2.0
1.03k stars 101 forks source link

fixed manageSubscriptions where it should call manageSubscription #89

Closed k0shk0sh closed 7 years ago

k0shk0sh commented 7 years ago

instead of manageViewSubscription in RxTiPresenterSubscriptionHandler

StefMa commented 7 years ago

Oh wow! Nice catch. Thank you 👍

Can you please add a test so that something like that will never happen again?! You can simple copy tests like this but call manageSubscriptions.

k0shk0sh commented 7 years ago

@StefMa sure, I'll write up that right now.

k0shk0sh commented 7 years ago

@StefMa didn't want to introduce something new, so I followed up manageSusbription tests.

passsy commented 7 years ago

Ouch, that was a good catch!

passsy commented 7 years ago

@StefMa please add a test for RxTiPresenterDisposableHandler#manageDisposables(Disposable...)