GCX-HCI / grandcentrix-AndroidCodeStyle

Android code style settings for Android Studio at grandcentrix
217 stars 63 forks source link

Move the Code Style to an IntelliJ Setting Repository #27

Open jreehuis opened 5 years ago

jreehuis commented 5 years ago

IntelliJ / Android Studio is lately changing the code style xml structure quite often when upgrading the IntelliJ / Android Studio version. This gets quite cumbersome to support as many as possible older versions of the IDE.

Other than that it also makes it hard to maintain the code style in a project repository as the devs get forced to use a set version or loose some features of the code style as the IDE does not understand the option any more.

Maybe we could adopt the code style to an IntelliJ settings repository? (https://www.jetbrains.com/help/idea/sharing-your-ide-settings.html#settings-repository)

passsy commented 5 years ago

The downside of this would be that when the settings aren't part of the project anymore and may change without a project specific commit. There is no option to select a specific commit/tag.

Btw: Be careful when testing it. Don't select this repo for testing, it overrides master and force pushes your local settings 😮

jreehuis commented 5 years ago

Unfortunately this is a big contra. I am not sure if such settings repository is the way to go, but I wanted to start a discussion about it. Currently we have the situation that some devs are using AS 3.4 and some 3.5 Beta. So at least one group will get automatically applied changes to the code style xml automatically stage upon commits. This is quite annoying and I do not like to tell a dev which exact IDE version he has to use if there is not real strong point.