search

GCX-HCI / grandcentrix-AndroidCodeStyle

Android code style settings for Android Studio at grandcentrix
217 stars 63 forks source link

update README part about copying the code style to project #33

Closed lukaszkalnik closed 5 years ago

lukaszkalnik commented 5 years ago

Android Studio apparently messes up the code style when it is copied directly to project via the install script. So the only path to import the code style into a project is to install it for the IDE and then import into the project via Android Studio settings.

StefMa commented 5 years ago

The install script is doing basically the same as the manual import... Not sure why it should break it. Apart from that you should also remove the install script if its really an issue 😉

On Tue, Sep 3, 2019, 5:07 PM lukaszkalnik notifications@github.com wrote:

Android Studio apparently messes up the code style when it is copied directly to project via the install script. So the only path to import the code style into a project is to install it for the IDE and then import into the project via Android Studio settings.

You can view, comment on, or merge this pull request online at:

https://github.com/grandcentrix/AndroidCodeStyle/pull/33 Commit Summary

  • update README part about copying the code style to project

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/grandcentrix/AndroidCodeStyle/pull/33?email_source=notifications&email_token=ACOBQ64Q73HBLYA4MJVHX2TQHZ4UPA5CNFSM4ITHPXN2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HJAM7FA, or mute the thread https://github.com/notifications/unsubscribe-auth/ACOBQ6ZBMN3XDLPUC4C7QJ3QHZ4UPANCNFSM4ITHPXNQ .

lukaszkalnik commented 5 years ago

The install script works correctly when used without the path parameter (i.e. when copying the code style to Android Studio settings, for all projects). The approach however doesn't work when copying the code style to a specific project (with the path parameter).

I have decided to just update the readme for now so there is no confusion. Also it anyway required update, as the names of the settings in Android Studio changed a little bit in the meantime.

StefMa commented 5 years ago

Could you please open a issue that we have to fix this sometime in the future? Thank you 👍

lukaszkalnik commented 5 years ago

Created an issue https://github.com/grandcentrix/AndroidCodeStyle/issues/34 Please let me know if you need additional information 👍