has lot of blocked operations reported from blockcanary

[eggcaker]

I saw lot of blocked reported from blockcanary when i cannot any type prefs read (getInt getBoolean), i have around 100 try items saved in TrayPreferences table. it should be very faster to read

[passsy]

Because tray supports multi process it is quite slow. It's also not intended to read/write tray preferences on the main thread. If you want something fast use the SharedPreferences but you'll lose multi process support.

[eggcaker]

if I have lot of read/write operation at same time, should I change to async call ?

[thelou1s]

Yes， me too。 ANR traces reported:

"main" prio=5 tid=1 Native | group="main" sCount=1 dsCount=0 obj=0x753b8598 self=0xf4f36500 | sysTid=18059 nice=0 cgrp=default sched=0/0 handle=0xf76d6d54 | state=S schedstat=( 0 0 0 ) utm=21 stm=55 core=2 HZ=100 | stack=0xff6bd000-0xff6bf000 stackSize=8MB | held mutexes= native: pc 0000000000041228 /system/lib/libc.so (ioctl+8) native: pc 0000000000047ca5 /system/lib/libc.so (ioctl+14) native: pc 000000000001e96d /system/lib/libbinder.so (_ZN7android14IPCThreadState14talkWithDriverEb+132) native: pc 000000000001efdf /system/lib/libbinder.so (_ZN7android14IPCThreadState15waitForResponseEPNS_6ParcelEPi+38) native: pc 000000000001f195 /system/lib/libbinder.so (_ZN7android14IPCThreadState8transactEijRKNS_6ParcelEPS1_j+124) native: pc 000000000001a11b /system/lib/libbinder.so (_ZN7android8BpBinder8transactEjRKNS_6ParcelEPS1_j+30) native: pc 000000000008d635 /system/lib/libandroid_runtime.so (???) native: pc 0000000000f38429 /system/framework/arm/boot.oat (Java_android_os_BinderProxy_transactNativeILandroid_os_Parcel_2Landroid_os_Parcel_2I+140) at android.os.BinderProxy.transactNative (BinderProxy.java) at android.os.BinderProxy.transact (BinderProxy.java:503) at android.app.ActivityManagerProxy.refContentProvider (ActivityManagerProxy.java:4339) at android.app.ActivityThread.releaseProvider (ActivityThread.java:6641)

• locked <0x0abceb12> (a android.util.ArrayMap) at android.app.ContextImpl$ApplicationContentResolver.releaseProvider (ContextImpl.java:2402) at android.content.ContentResolver$CursorWrapperInner.close (ContentResolver.java:2605) at net.grandcentrix.tray.provider.TrayProviderHelper.persist (TrayProviderHelper.java) at .persist (TrayProviderHelper.java) at .queryProvider (TrayProviderHelper.java) at .cursorToTrayItem (TrayProviderHelper.java) at net.grandcentrix.tray.provider.ContentProviderStorage.getVersion (ContentProviderStorage.java) at .put (ContentProviderStorage.java) at .put (ContentProviderStorage.java) at .setVersion (ContentProviderStorage.java) at .get (ContentProviderStorage.java) at net.grandcentrix.tray.core.Preferences.put (Preferences.java) at .put (Preferences.java) at .put (Preferences.java) at .getStorage (Preferences.java) at .onUpgrade (Preferences.java) at .changeVersion (Preferences.java)
• locked <0x03fbc2e3> (a net.grandcentrix.tray.a) at net.grandcentrix.tray.core.Preferences.isVersionChangeChecked (Preferences.java) at net.grandcentrix.tray.core.Preferences. (Preferences.java) at net.grandcentrix.tray.core.AbstractTrayPreference. (AbstractTrayPreference.java) at net.grandcentrix.tray.TrayPreferences. (TrayPreferences.java) at . (TrayPreferences.java) at net.grandcentrix.tray.TrayPreferences. (TrayPreferences.java) at . (TrayPreferences.java) at net.grandcentrix.tray.AppPreferences. (AppPreferences.java) at x.y.z.App.onCreate (App.java) at android.app.Instrumentation.callApplicationOnCreate (Instrumentation.java:1037) at android.app.ActivityThread.handleBindApplication (ActivityThread.java:6422) at android.app.ActivityThread.access$1800 (ActivityThread.java:229)

[passsy]

Handle Tray like a database. You wouldn't read/write data on the main thread. Move the code to some other Thread.

The API isn't async because most times you use Tray you have a mutliprocess case mostly without UI where you anyways shouldn't run blocking code on the main thread. (i.e. handle some FCM Notification in a Service, SyncAdapter, BroadcastReceiver, TileService, ...)

Short: Don't run Tray on the main thread, make it async when you use it in your Activities. All non UI stuff should be already off the main thread, use the synchronous API there.