Make sure preference key value is not empty.

GCX-HCI / tray

a SharedPreferences replacement for Android with multiprocess support

Apache License 2.0

2.29k stars 272 forks source link

Make sure preference key value is not empty. #84

Closed eyedol closed 8 years ago

eyedol commented 8 years ago

Fixes #64

This PR makes the following changes:

When a preference key is empty, an illegalArgumentException is thrown. This prevents empty string being passed to the underling storage engine from throwing an error with an unclear message.
Add tests for this fix.

codecov-io commented 8 years ago

Current coverage is 100% (diff: 100%)

Merging #84 into master will not change coverage

@@           master   #84   diff @@
===================================
  Files          22    22          
  Lines         656   659     +3   
  Methods         0     0          
  Messages        0     0          
  Branches       97    98     +1   
===================================
+ Hits          656   659     +3   
  Misses          0     0          
  Partials        0     0

Powered by Codecov. Last update b96400d...b19dbd6

passsy commented 8 years ago

LGTM 🚢

eyedol commented 8 years ago

@jreehuis updated the JavaDoc per your request