search

GCX-HCI / tray

a SharedPreferences replacement for Android with multiprocess support
Apache License 2.0
2.29k stars 272 forks source link

Weaken Parameter type for clearBut Methods #89

Closed jannisveerkamp closed 7 years ago

jannisveerkamp commented 7 years ago

clearBut() methods should only need an instance of AbstractTrayPreference instead the concrete implementation TrayPreference.

Since we are only weakening the type of the parameter it should not break anything.

This is needed in case you're using an alternative Implementation.

@passsy

codecov-io commented 7 years ago

Codecov Report

Merging #89 into master will not impact coverage.

@@           Coverage Diff            @@
##             master    #89    +/-   ##
========================================
  Coverage       100%   100%            
- Complexity        0    271   +271     
========================================
  Files            22     22            
  Lines           659    659            
  Branches         98     57    -41     
========================================
  Hits            659    659
Impacted Files Coverage Δ Complexity Δ
...rary/src/main/java/net/grandcentrix/tray/Tray.java 100% <ø> (ø) 8 <ø> (+8) :white_check_mark:
...grandcentrix/tray/provider/TrayProviderHelper.java 100% <100%> (ø) 21 <ø> (+21) :white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 192b10d...caccae5. Read the comment docs.