GCX-HCI / tray

a SharedPreferences replacement for Android with multiprocess support
Apache License 2.0
2.29k stars 273 forks source link

Update minimum sdk version to 8 (FROYO) #94

Closed gryphon2411 closed 7 years ago

gryphon2411 commented 7 years ago

Update library required system minimum API level from API 15 (ICE_CREAM_SANDWICH_MR1) to API 8 (FROYO).

This update will let this library to be available for usage in many more android projects which require lower API level than 15.

When attempting to decrease the minSdkVersion attribute value to < 8, (for example, 7) the following gradle build error occurs:

Error:Execution failed for task ':library:processDebugAndroidTestManifest'.
> java.lang.RuntimeException: Manifest merger failed : uses-sdk:minSdkVersion 7 cannot be smaller than version 8 declared in library [com.android.support.test:runner:0.4]
    Suggestion: use tools:overrideLibrary="android.support.test" to force usage

This is the lowest API level available without any changes to either source code or dependencies. This update passes all instrumented tests.

codecov-io commented 7 years ago

Codecov Report

Merging #94 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             master    #94   +/-   ##
=======================================
  Coverage       100%   100%           
  Complexity      271    271           
=======================================
  Files            22     22           
  Lines           659    659           
  Branches         57     57           
=======================================
  Hits            659    659

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4ece993...194d408. Read the comment docs.

passsy commented 7 years ago

We're not going to official support such old versions.

Use this as workaround in your AndroidManifest

    <!-- override the min sdk version -->
    <uses-sdk tools:overrideLibrary="net.grandcentrix.tray" />

We're considering 14 as min sdk for the future. Everything else is out of scope. Even the support library will drop support for older versions