search

GChristensen / torrent-add

GNU General Public License v3.0
14 stars 1 forks source link

PLEASE add some indication if it's connected! #13

Closed ckramer closed 4 months ago

ckramer commented 5 months ago

This is the best torrent extension, thank you!

But such pain to use it because there's no indication if it's connected or not. it may lose connection to qbittorrent and you may be adding torrents but they go nowhere and there's no indication.
And to connect I go to options click the power plug icon, and refresh many times. and then to test if it connected I try to add torrent, then go to qbittorrent to check if it added. If not open extension options and click refresh again and again.

Earlier it was possible to know if it's connected because it populated categories from client. And when you add it will show empty list "add to". Now it doesn't erase categories when it lost connection. and you add torrents thinking all is fine to find hour later that all 20 torrents you added went nowhere and all list. And then again, go to extension options, and click refresh , reload it endlessly until it may work or not.

Please add some feedback to show if it's connected or failed! When adding, maybe notification "successfully added". Or at least on Addon options some text if there's error connecting.

GChristensen commented 5 months ago

Hi, the extension obligatory notifies when it can not add a torrent because the torrent can not be downloaded or the client is unreachable. I'll try to investigate this.

ckramer commented 5 months ago

Notifies with browser notification or some other method?

On Fri, 26 Apr 2024 at 7:03 AM, GChristensen @.***> wrote:

Hi, the extension obligatory notifies when it can not add a torrent because the torrent can not be downloaded or the client is unreachable. I'll try to investigate this.

— Reply to this email directly, view it on GitHub https://github.com/GChristensen/torrent-add/issues/13#issuecomment-2078171630, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAWJY5N55GDTBDIP7URK2DY7FVSFAVCNFSM6AAAAABGZTL7RWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZYGE3TCNRTGA . You are receiving this because you authored the thread.Message ID: @.***>

GChristensen commented 5 months ago

Yes, browser popups, they may be muted in the OS settings.

ckramer commented 5 months ago

Ok, I get this "Add torrent notification". I just thought it's from qbittorrent. image

But torrent is not added actually. And no "add torrent" in qbittorrent logs. While if I add torrent by other means, it appears in Qbit and Qbit log.

If I shut down qbit there's no notifications and categories disappear. Could this mean "Add torrent" is not fully transactional event, so to say. It's sent to qbit's address successfully, but without acknowledgement that it was accepted?

GChristensen commented 5 months ago

No, it looks like this. I've checked, it appears (after some time, since it waits for connection timeout) if qbittorrent is shut down. Screenshot 2024-04-26 120202

GChristensen commented 5 months ago

Works both on chrome and firefox... Screenshot 2024-04-26 120644

I'ts very strange that there is no proper notification text in your case. I guess, it's mac?

GChristensen commented 5 months ago

Since there are no events that fire when the context menu is opened, it's quite hard to check the client availability at this time. In v0.5 there will be the [refresh] context menu at the torrent client categories mode.