search

GCuser99 / SeleniumVBA

A comprehensive Selenium wrapper for browser automation developed for MS Office VBA running in Windows
MIT License
89 stars 18 forks source link

Automatic WebDriver download/alignment #30

Closed GCuser99 closed 2 years ago

GCuser99 commented 2 years ago

Discussed in https://github.com/GCuser99/SeleniumVBA/discussions/29

Originally posted by **6DiegoDiego9** September 17, 2022 I believe that making SeleniumVBA work out-of-the-box is very important to make it popular. Automatic WebDriver download/alignment also helps in making it portable on multiple own machines. This is why today I'm working on this: *** Automatic WebDriver download/alignment optimizations: - auto-proxy (if any) is now used to download WebDriver (tested working on my business PC) - checkDriverBrowserVersionAlignment switch removed. The WebDriver download/alignment procedure is now called just when needed, inside (pre-existing) error handling, i.e. when WebDriver file doesn't exist or after it's called and an error specifically stating wrong-version occurs. The result is like a permanent (now removed) "checkDriverBrowserVersionAlignment = True" without the overhead of always checking in advance for driver version alignment. - WebDriver path changed to user PC temporary folder (VBA.environ("Temp")) to avoid conflicting WebDriver files when multiple users, with possibly different browsers, work with WebDriver files stored on a network folder. Not user configurable. *** @GCuser99 are you OK with this change? I read that you didn't "checkDriverBrowserVersionAlignment = True" because of insufficient testing. I can say that I'll commit myself to make it work flawlessy because it's important to me.