search

GDATASoftwareAG / Graylog-Plugin-AlertManager-Callback

A plugin for Graylog which provides the possibility to send alerts to the Prometheus AlertManager API.
MIT License
24 stars 5 forks source link

feature: customize labels and annotations #2

Closed StefanHufschmidt closed 5 years ago

StefanHufschmidt commented 5 years ago

This should empower the user to set custom annotations and labels which are submitted to the AlertManager when the alert will be send.

codecov-io commented 5 years ago

Codecov Report

Merging #2 into develop will decrease coverage by 1.33%. The diff coverage is 84.21%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop       #2      +/-   ##
=============================================
- Coverage      89.06%   87.73%   -1.34%     
- Complexity        61       69       +8     
=============================================
  Files              8        9       +1     
  Lines            128      163      +35     
  Branches           9       12       +3     
=============================================
+ Hits             114      143      +29     
- Misses            11       17       +6     
  Partials           3        3
Impacted Files Coverage Δ Complexity Δ
...nagercallback/CustomPropertiesTextFieldParser.java 100% <100%> (ø) 5 <5> (?)
...lertmanagercallback/AlertManagerAlarmCallback.java 90.47% <76.47%> (-9.53%) 8 <2> (ø)
...ertmanagercallback/AlertManagerPayloadBuilder.java 93.75% <83.33%> (-3.55%) 27 <0> (+3)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7e5bacb...4a84c99. Read the comment docs.

jschaefer-pott commented 5 years ago

Looks fine. Can be merged into develop