search

GDATASoftwareAG / vaas

Verdict-as-a-Service SDKs: Analyze files for malicious content
https://www.gdata.de/business/security-services/verdict-as-a-service
MIT License
36 stars 11 forks source link

PHP: Go async with AMP #451

Open lennartdohmann opened 5 months ago

lennartdohmann commented 5 months ago

Use AMPHP to go async

unglaublicherdude commented 4 months ago

I tested the implementation on an IONOS webhosting (shared-hosting) server and it does run there. :+1:

unglaublicherdude commented 1 month ago

We ran into an issue with async php by using the revolt/eventloop (dependency of the amphp packgages).

The nextcloud-app fails (only in the ci) when updating the http-client to the amphp one.

There is an issue with the revolt/eventloop and opcache which we can workaround by deactivate the opcache for the vendor/amphp directory. But for now, we decided to don't put anymore effort into this.

I opened this https://github.com/revoltphp/event-loop/issues/95. I opened this https://github.com/amphp/http-client/issues/365.

With this issue, this PR is also basically obsolete too.

What we still have to do is to revert the http-client to the guzzle one or to build a factory that creates an http-client regarding to some ini-settings (opcache.enabled would lead to good old guzzle).