Golang/destroy connections - Githubissues

GDATASoftwareAG / vaas

Verdict-as-a-Service SDKs: Analyze files for malicious content

https://www.gdata.de/business/security-services/verdict-as-a-service

MIT License

36 stars 10 forks source link

Golang/destroy connections #638

Open pstadermann opened 3 weeks ago

pstadermann commented 3 weeks ago

A rather large change with alpha status:

Connect() is obsolete. The connections are handled opaque.
Better error handling (with lots of room to go)
Use zap for debug logging
Go routines don't write to shared state

Open questions:

Can we modify New and Connect to be backwards compatible (no v3 necessary)
Does the logging integrate into your solution? What do we have to change?
Are the cloud protection bugs gone?

TODO:

Review and fix stuff
Test coverage (error handling!)