search

GDColon / URLX

A rhythm game played in your browser's address bar
https://gdcolon.com/urlx
47 stars 7 forks source link

Inputs / hit sounds are played at the BPM of the song at the time of placement instead of the proper song BPM setting #2

Closed jbmagination closed 2 years ago

jbmagination commented 2 years ago

I'm not sure what else I can add to this. Running on Chrome 97.0.4692.102

GDColon commented 2 years ago

Can you record a video? Works find on my end.

jbmagination commented 2 years ago

Just tried on Firefox 98.0.2 and I can reproduce. Will fiddle with OBS since for some reason today it doesn't want to let me add anything to my scenes

jbmagination commented 2 years ago

I tried setting the BPM to 200 and yeah, inputs and hit sounds are at 100bpm while the rest (address bar / metronome) isn't. Autoplay handles it fine though and does inputs at 100bpm. A human player... couldn't do that probably

jbmagination commented 2 years ago

I've changed the title as I've now discovered why they were "horribly off".

Here's the .urlzip and .urlx. My current computer's recordings suck absolute balls so I'll re-record with a video on my other computer ASAP

GDColon commented 2 years ago

Hmm, this most likely means that the notes aren't being updated correctly. Does the issue persist after typing game.conductor.updateActionSecs() in the console?

Nadwey commented 2 years ago

I was able to reproduce this issue, and running game.conductor.updateActionSecs() fixed it...

https://user-images.githubusercontent.com/81181783/165526193-ab974ccc-e943-4fc4-bbf2-a1566eb09c96.mp4

GDColon commented 2 years ago

Aha yeah, most timings in the game are stored in seconds instead of beats (because of bpm changes, etc), I guess they just didn't update. You can even see the function failing in the video above, how convenient

GDColon commented 2 years ago

Fixed in latest update, I wrote this.conductor instead of this.game.conductor. Thank you for showing the error in the console!

Nadwey commented 2 years ago

Fixed in latest update, I wrote this.conductor instead of this.game.conductor. Thank you for showing the error in the console!

I didn't even notice them, because brave is always showing me them lol