search

GDD-Nantes / FedShop

Code for FedShop: The Federated Shop Benchmark
GNU General Public License v3.0
8 stars 0 forks source link

several edits in the README #46

Closed hartig closed 1 year ago

hartig commented 1 year ago

@mhoangvslev please review and merge if you are fine with these edits

hartig commented 1 year ago

Okay, I have changed it back (see commit https://github.com/mhoangvslev/FedShop/pull/46/commits/c0871a71c7e49fefc6d531f22387cbd5dc6589c4).

Notice, however, that I don't actually agree with this term and that I think whoever wrote this term in their papers is using the English language wrongly. In this term, "federated" is an adjective for "query engine" but the query engines are not federated.

mhoangvslev commented 1 year ago

I see your point. How about we hyphenate it like this: "federated-query engine", similar to "short-term memory" or "mixed-gender education"?

hartig commented 1 year ago

How about we hyphenate it like this: "federated-query engine"

Okay, done. See commit https://github.com/mhoangvslev/FedShop/pull/46/commits/60f74197d374a8ffe9b832972824d5fb622fbcc0