GDG-GANDHINAGAR / devfest-19

DevFest Gandhinagar 2019 Website
9 stars 10 forks source link

Filters Added for speaker #108

Closed pAditya198 closed 5 years ago

pAditya198 commented 5 years ago

When None of the Filters are selected :

Screenshot (150)

When Machine Learning is Selected as Filter :

Screenshot (151)

When Mobile is Selected as Filter :

Screenshot (152)

pAditya198 commented 5 years ago

Schedule Component Also Initialized linked with speakers firebase

With dummy_data :

Screenshot (153)

With data :

Screenshot (154)

pAditya198 commented 5 years ago

@samagragupta @aashutoshrathi Please review

Also Some UI fixes needed.

related to issue #81

pAditya198 commented 5 years ago

Instead of button I've used Checkbox they look more classic and also less variables are used. Some screenshot are provided below as an example of multiple checks.

Screenshot (156)

Screenshot (157)

Screenshot (158)

Screenshot (159)

pAditya198 commented 5 years ago

Review changes are also fixed @aashutoshrathi

pAditya198 commented 5 years ago

@aashutoshrathi should I create a new model for schedule because here I'm using the existing data from speakers

AmanRaj1608 commented 5 years ago

@samagragupta @aashutoshrathi Is this schedule UI okay https://github.com/pAditya198/devfest-19/pull/7

aashutoshrathi commented 5 years ago

@samagragupta Check once more, we will merge it then

pAditya198 commented 5 years ago

@samagragupta @aashutoshrathi Is this schedule UI okay pAditya198#7

@samagragupta @aashutoshrathi suggest UI changes or should I just merge this commit.

parth181195 commented 5 years ago

can nu finish the change @aashutoshrathi has requested so i can merge this in master