search

GDG-Nantes / DevfestNantesMobile

KMM Mobile repo for the Android and iOS mobile app of the DevFest Nantes.
https://devfest.gdgnantes.com/
Apache License 2.0
12 stars 2 forks source link

Feature: sort room filters like on the official website #88

Open jtanguy opened 2 years ago

jtanguy commented 2 years ago

It seems that the room filters are sorted alphabetically, instead of the order presented on the website (it seems that they are ordered by capacity, but I'm not sure). It I'll be easier to use the room filters (the big room first instead of third)

Screenshot_20221017-142300.jpg

RobinCaroff commented 2 years ago

@jtanguy Thanks for submitting the issue! Good thinking, it would make more sens indeed.

We cannot automatically deduce the importance of the rooms from the data provided by the DevFest Nantes's repo(https://github.com/GDG-Nantes/Devfest2022/tree/master/data) and we would need this info to setup sorting on our backend side.

I'll keep this issue opened as I'm sure we can do this for next year.

jtanguy commented 2 years ago

We could keep the order in the rooms. Inside schedule.json, there is an array of rooms, which has some sort.

jtanguy commented 2 years ago

Did we loose the sort when casting into a Set ?

RobinCaroff commented 2 years ago

Good idea! Yes indeed we could use this order; however I'll need to update the sorting algorithm on the app's side as it groups sessions by start times but the does not sort the sessions by rooms. I fear that the update won't make it to production before the start of the event (review process is currently awfully long...). I'll let you know how it goes!

RobinCaroff commented 1 year ago

Done for Android in #149