search

GDG-OnCampus-BU / landing-page-WIP

Google Developers Group Bennett University, Landing Page
0 stars 10 forks source link

Issue #3: Make the nav bar transition smooth and intuitive #8

Closed genial-mani closed 6 days ago

genial-mani commented 1 week ago

This is the final result after fixing the issue.

localhost_3000_-GoogleChrome2024-10-0300-23-43-ezgif com-crop

if you like it please merge the PR.

genial-mani commented 1 week ago

could you please add hacktoberfest topic to the repo or to the pr please.

g4ze commented 1 week ago

great work! can you pls follow the PR template for an easy merge?

genial-mani commented 1 week ago

Yes, I already followed the same:

Important Checklist:

  1. You have prettyfied your code (npx prettier --write .)
  2. Linted the code using ESLint (npx eslint . --ext .js,.jsx,.ts,.tsx)
  3. This code is best you could write in terms of quality (we don't mind even if its bad :P)
  4. You have attached the screenshot of visible chnages in GUI, if any
  5. You have no merge conflicts, you have pulled and rebased your PR branch
  6. All CI tests have passed

also if you have any queries bring them to the table. if you don't have any queries merge the PR after adding hacktoberfest topic to the repo/PR.