GDG-Ukraine / gdg.org.ua

GDG Ukraine website, event registration forms.
http://gdg.org.ua/
MIT License
6 stars 24 forks source link

[#37] Update design of confirmation letter #117

Open cleac opened 8 years ago

cleac commented 8 years ago

Resolves #37

Implement the updated design of confirmation letter.

@webknjaz @bluebirrrrd @anxolerd: give your suggestions of text improvements

anxolerd commented 8 years ago

Hey, @bluebirrrrd ! We know you're a super-dupa busy person, but could you please help us with the text of confirmation letter? We really need your help and advise ;)

bluebirrrrd commented 8 years ago

Hey guys,

I'll skip the part with criticism and just modify the @cleac's version below.

begin-part

Thanks for registering to the event "{{ event.title }}". Please confirm your attendance by clicking the button below.

<div style="text-align:center">
  <a href="http://reg.gdg.org.ua/some/confirmation/url" style="display: block; background-color: #1c90f3;
    width: 100px; color: #eee; border-radius: 5px; text-decoration: none; padding: 10px; font-family: arial;">I will come</a>
</div>

If you have decided not to come, just ignore this letter.

end-part

Also, adding some time limits for confirmation would be nice. I skipped this part since we don't have any features for that at the moment.

[Advice] Please read The art of business correspondence by Sasha Karepina before writing any letters of confirmation. I believe all of you will find it very helpful for further mailing (& discussions on github as well).

webknjaz commented 7 years ago

@cleac

cleac commented 7 years ago

Currently have some work and univ's routine. Will do ASAP :smile:

webknjaz commented 7 years ago

@cleac status?

cleac commented 7 years ago

@webknjaz WIP cause too much time left from time I started this PR

anxolerd commented 7 years ago

@cleac: ping What is left to be done? Maybe @webknjaz and I can accomplish that while you are busy?

anxolerd commented 7 years ago

@cleac ping

cleac commented 7 years ago

Hi all, sorry for losing touch. I will finish this PR today, currently working on it :smiley:

cleac commented 7 years ago

@webknjaz @anxolerd

I decided to use mjml framework for this. After trying several of them, it looks the best and easiest as for me.

I will make detached header with GDG logo and text which have to be in every single email, like hi, pal in separate mjml file, like header.mjml for it to be easily included into every email template file and mask all html files in that folder in gitignore. Here is a conceptual implementation of concept: example. I'll make implementation in repo and push it here a bit later today

The only drawback I've found - we will have to put only absolute urls in the letter.

webknjaz commented 7 years ago

The only drawback I've found - we will have to put only absolute urls in the letter.

sounds ok

webknjaz commented 7 years ago

@cleac I've implemented a set of url_for() resolvers, which produce absolute URLs, they are available in jinja2 templates

cleac commented 7 years ago

I've implemented a set of url_for() resolvers, which produce absolute URLs, they are available in jinja2 templates

@webknjaz awesome! :-)

cleac commented 7 years ago

@webknjaz is there any doc on url_for you mentioned above? I'd like to use it, but don't know where should I search it :-)

webknjaz commented 7 years ago

https://github.com/GDG-Ukraine/gdg.org.ua/blob/master/src/tests/test_utils.py#L16-L76 https://github.com/GDG-Ukraine/gdg.org.ua/blob/master/src/GDGUkraine/lib/utils/url.py#L201-L295

cleac commented 7 years ago

It seems that thats all on task :-) @webknjaz @anxolerd @bluebirrrrd please, check it out

webknjaz commented 7 years ago

@cleac any tests?

cleac commented 7 years ago

I'll write down some tests later today

cleac commented 7 years ago

@webknjaz @anxolerd I won't have much time this week (preparing for a new position interview), please check it out and leave comments for reasonable issues. I'll add several unit tests a bit later in another PR if you don't mind :wink:

cleac commented 7 years ago

Finish #117

cleac commented 7 years ago

@webknjaz @anxolerd Guys, can you pls check out this PR? I've fixed the script