Closed abhinav-adtechs closed 6 years ago
@abhinav-adtechs I'd like to take this one.
@abhinav-adtechs It will a good idea to use Bootstrap for layout. Can I use its CDN to add Download App section? Also, I saw you're using two code block for sponsors, first for the desktop version and another one for mobile or medium-sized devices. This kind of coding standard increases the redundancy of the code. It would a good idea to use Bootstrap for such kind of requirement. It will automatically detect and produce the code according to the size of the device. Thanks
@rowhitswami appreciate your contribution. I'd let the repository moderators to take the call, thanks. @UjjwalAyyangar please see.
@rowhitswami Please do ! Make sure that nothing breaks in the process. We will merge based on the quality of your pull. Also once you are done, post the screenshots here. Cheers
@aalind0 sure..thanks
@rowhitswami bootstrap shouldn't be added to the project. the project already uses materializecss. materialize also has a grid system. use that instead. remove the redundancy if possible.
Note : All non-critical css files are bundled together using gulp and added asynchronously inside script.js using loadCSS. this is done to optimize pagespeed, adding cdn version to the index.html will be render-blocking and will delay the initial render.
PS: you don't have to worry about any of this, just go ahead and modify index.html in src folder.
@technophilic Ok I'll use materializecss
Sponsors Section
Download App Section
And here mobile view of both changes
There's no iOS application being built currently, please remove it.
@abhinav-adtechs Okay.
@abhinav-adtechs removed. Please review PR #26
Please add the download app section as soon as the app is ready.