search

GDGVIT / pip-gui

A GUI based Python Package installer
GNU General Public License v3.0
91 stars 24 forks source link

Refactored code for directory changes #30

Closed Geek-ubaid closed 4 years ago

Geek-ubaid commented 4 years ago
pull-assistant[bot] commented 4 years ago
Score: 0.91

Best reviewed: commit by commit

Optimal code review plan (2 warnings)

     removed unwanted comments and unused code
Resource directory improved
> `pipgui/refreshLists.py` 67% changes removed in some logging stateme...
     Merge branch 'master' of https://github.com/Geek-ubaid/pip-gui      fixed directory issues
conflicts resolved
> `pipgui/Scraping/genreList.py` 57% changes removed in fixed dir issues, re... > `pipgui/Scraping/packageList.py` 75% changes removed in fixed dir issues, re... > `...ge_Management/installedList.py` 67% changes removed in refresh pacakge work... > `pipgui/Scraping/pypiList.py` 50% changes removed in fixed dir issues, re...
     fixed dir issues, refactored a bit      refresh pacakge working      removed the version from readme      some logging statements added      Merge branch 'master' of https://github.com/Geek-ubaid/pip-gui

Powered by Pull Assistant. Last update f96ad51 ... 4698e71. Read the comment docs.

pep8speaks commented 4 years ago

Hello @Geek-ubaid! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 20:80: E501 line too long (102 > 79 characters) Line 21:80: E501 line too long (104 > 79 characters)

Line 21:80: E501 line too long (100 > 79 characters) Line 22:80: E501 line too long (102 > 79 characters)

Line 12:80: E501 line too long (81 > 79 characters) Line 27:80: E501 line too long (96 > 79 characters) Line 28:80: E501 line too long (95 > 79 characters) Line 29:80: E501 line too long (91 > 79 characters)

Line 5:80: E501 line too long (106 > 79 characters)

Line 14:1: E305 expected 2 blank lines after class or function definition, found 1 Line 14:80: E501 line too long (81 > 79 characters) Line 19:80: E501 line too long (109 > 79 characters) Line 20:80: E501 line too long (108 > 79 characters) Line 23:80: E501 line too long (102 > 79 characters) Line 36:80: E501 line too long (114 > 79 characters) Line 38:80: E501 line too long (100 > 79 characters)

Line 17:80: E501 line too long (93 > 79 characters)

Line 30:1: W293 blank line contains whitespace Line 71:80: E501 line too long (97 > 79 characters) Line 72:1: W293 blank line contains whitespace Line 76:1: W293 blank line contains whitespace Line 147:80: E501 line too long (97 > 79 characters) Line 220:80: E501 line too long (97 > 79 characters) Line 222:80: E501 line too long (113 > 79 characters) Line 254:80: E501 line too long (118 > 79 characters) Line 266:80: E501 line too long (118 > 79 characters) Line 290:80: E501 line too long (97 > 79 characters) Line 292:80: E501 line too long (115 > 79 characters) Line 322:80: E501 line too long (114 > 79 characters) Line 339:80: E501 line too long (114 > 79 characters) Line 365:80: E501 line too long (97 > 79 characters) Line 367:80: E501 line too long (115 > 79 characters) Line 369:80: E501 line too long (109 > 79 characters) Line 404:80: E501 line too long (120 > 79 characters)

Line 4:80: E501 line too long (91 > 79 characters) Line 13:1: W293 blank line contains whitespace Line 20:1: W293 blank line contains whitespace

Comment last updated at 2020-06-14 17:01:03 UTC
r00tdaemon commented 4 years ago

Please squash the commits before merging