GDQuest / blender-power-sequencer

Add-on for video editing in Blender 3D: edit videos faster! Included in Blender 2.81+
https://gdquest.com/blender/power-sequencer/
GNU General Public License v3.0
708 stars 58 forks source link

Fixes Powersequencer Operator: scene_create_from_selection #430

Closed Modicolitor closed 4 years ago

Modicolitor commented 4 years ago

-removed error when no strip is selected

...hope that it helps

Please check if the PR fulfills these requirements:

Related issue (if applicable): #

What kind of change does this PR introduce? -removed error when no strip is selected

Does this PR introduce a breaking change? I quess, renaming the scene after the active strip is not breaking change, but however a question of taste. I think it gives a better overview when working with this awesome operator

New feature or change

What is the current behavior? scene from strip operator creates error when nothing is selected scene from strip operator creates error on runtime because code for changing the scene was wrong

What is the new behavior?

both error fixes 1. by checking that a strip is at least selected. 2. change the code during scene chage

Other information There is still no UI entry for the operator, now that its working again, maybe that's a next step

love helping, when this is helpful

NathanLovato commented 4 years ago

Thanks for your contribution, I merged manually in 31268b03d987de3d43ec3b9dfcc2c2e67752ff31. Your help is much appreciated!

Modicolitor commented 4 years ago

Awesome, I'll see what other bugs I see. Love powersequencer . Helps a lot 😀

NathanLovato commented 4 years ago

Thanks much! Suggestions for improvements are also welcome.

If you don't mind, could you check our commit guidelines for future contributions?

In short:

1. Separate subject from body with a blank line
2. Keep the subject line under 72 characters
3. Capitalize the subject line
4. Do not end the subject line with a period
5. Use the imperative mood in the subject line
6. Wrap the body at 72 characters
7. Use the body to explain what and why vs. how

This helps me with maintaining our many free software projects.