GDQuest / blender-power-sequencer

Add-on for video editing in Blender 3D: edit videos faster! Included in Blender 2.81+
https://gdquest.com/blender/power-sequencer/
GNU General Public License v3.0
708 stars 58 forks source link

Channel offset with Down direction crashes Blender #447

Closed RichardAntalik closed 3 years ago

RichardAntalik commented 3 years ago

I'm submitting a...

Bug report

Channel offset with Down direction crashes Blender if executed with strip in channel 1 selected

What is the current behavior? Blender crashes

What is the expected behavior? Blender not crashing, other than that not sure.

Tell us the steps to reproduce the bug, and if possible share a minimal demo of the problem. untitled.zip Open file Press Ctrl+Alt+Down arrow

Other information See https://developer.blender.org/T82942, why this is not bug in Blender

This should resolve crashing in this case.

diff --git a/operators/utils/functions.py b/operators/utils/functions.py
index b7d29dc..f24ca48 100644
--- a/operators/utils/functions.py
+++ b/operators/utils/functions.py
@@ -321,10 +321,9 @@ def delete_strips(to_delete):
     """
     if not to_delete:
         return
-    bpy.ops.sequencer.select_all(action="DESELECT")
+    sequences = bpy.context.sequences
     for s in to_delete:
-        s.select = True
-    bpy.ops.sequencer.delete()
+        sequences.remove(s)
NathanLovato commented 3 years ago

Thanks Richard, I'm marking it to fix today, along with merging the waiting PR, and I'll update the add-on in Blender.