GDQuest / krita-batch-exporter

A Free Krita plugin to batch export layers and groups with maximum flexibility. Scale, trim, export multiple copies of your layers...
GNU General Public License v3.0
313 stars 27 forks source link

Add metadata inheritance from parent groups and option to not inherit the metadata #57

Closed sihlecodes closed 2 years ago

sihlecodes commented 2 years ago

Please check if the PR fulfills these requirements:

Related issue (if applicable):

What kind of change does this PR introduce?

Fixes bug #49 Small UI change Introduces a new feature

Does this PR introduce a breaking change?

Not 100% sure. But all my tests went as expected.

New feature or change

Introduces a feature I call "metadata inheritance", which allows group layers that are not marked for export to share their metadata to child layers. Reduces the clutter in layer names and makes it easier to organize larger documents.

Introduced a new tag i=no|false which makes layers ignore all inherited metadata. Group Layers can still share their own defined metadata with their children when marked with i=.

What is the current behavior?

Layers have to be multi selected to change, often similar, metadata.

What is the new behavior?

A single group layer can share common metadata tags to child layers while still allowing child layers to override those tags if needed.

Other information

Fixed #49 Changed the update button on the UI to be inline with the line edit and replaced the "Update" text with the "view-refresh" icon.

razcore-rad commented 2 years ago

I gave it a quick look and try, it's a really nice contribution, thanks a lot.

NathanLovato commented 2 years ago

We need to contribute the changes to Krita as well. If you have a KDE gitlab account, could you do it @razcore-rad? All we need to do is update the addon files. Perhaps rename one or two as well, I don't remember exactly.

Here's the source repository: https://invent.kde.org/graphics/krita