GDQuest / learn-gdscript

Learn Godot's GDScript programming language from zero, right in your browser, for free.
https://gdquest.github.io/learn-gdscript/
Other
2.11k stars 160 forks source link

Lesson 23, gem names, based on symbols or colors #408

Closed duianto closed 2 years ago

duianto commented 2 years ago

Issue description:

In Lesson 23, maybe the gem names, should be based on symbols or on the gem colors.

To Reproduce Steps to reproduce the bug:

  1. Go to https://gdquest.github.io/learn-gdscript/staging/#course/lesson-23-append-to-arrays/lesson.tres
  2. Scroll down to the heading: Using arrays as stacks
  3. See the gem names in both stacks examples.

Observed behavior

The gem names in the second example are:

Maybe the gem names should be changed to either:

duianto commented 2 years ago

The output messages in lesson 23, practice exercise: Clearing up the crates https://gdquest.github.io/learn-gdscript/staging/#course/lesson-23-append-to-arrays/practice-B7tKRHJM.tres

Calls the gems:

and there's a fourth gem without a symbol that's just called: gem

yAgXXsRx7d

msedge_eYbxb3VGiY

duianto commented 2 years ago

The fire/red gem is called red gem in the first example in lesson 24: https://gdquest.github.io/learn-gdscript/staging/#course/lesson-24-access-array-indices/lesson.tres

msedge_y5eBPBSBqt

The order of the gems in the left panel, doesn't match the names in the inventory variable. I'll open a separate issue about it.

duianto commented 2 years ago

In lesson 24's exercise, Using the right crystals https://gdquest.github.io/learn-gdscript/staging/#course/lesson-24-access-array-indices/practice-ErO9L4MW.tres

The error message uses the names of the symbols on the gems:

msedge_txWgsaYvir

But the Goal uses the gem colors.

msedge_JfihiXqp5B

Expected

Maybe the error message also should use color names, because at least two of the gems don't have symbols on them: white and green

As mentioned above: https://github.com/GDQuest/learn-gdscript/issues/408#issuecomment-1058916473 The white gem seems to just be called gem, which might be to generic.