In lesson 24's exercise, `Using the right crystals`, no pink gem

duianto commented 2 years ago

Describe the bug

The Goal ask us to use the pink and yellow gems, but there is no pink gem.

To Reproduce Steps to reproduce the bug:

Go to https://gdquest.github.io/learn-gdscript/staging/#course/lesson-24-access-array-indices/practice-ErO9L4MW.tres
In the left panels Goal section, read the second paragraph:

They want to use the pink and yellow crystals to buff their characters. Like before, we need to find them in the array.

But there is no pink gem in the grid of gems.

Expected behavior

Since the accepted solution shows the message:

using item 5: "fire pickup"

Then it seems like the pink color should be changed to: red

Screenshots

msedge_umgZVD48vT

Information about your device (please complete the following information):

Xananax commented 2 years ago

I changed the text to say "fire" and "lightning" in dbdae73a1365107d48a392f93133195875874f3a, but I'm not sure it's much better.

I suggest to either have the gems with their names at the top of the display, or to use embed images in the text

Xananax commented 2 years ago

This is also related to #408

We could also not use gems at all, and use sword/potion/coin/shield instead, which are much less confusing (and better for colorblind people)

johnnygossdev commented 2 years ago

I like using completely different items more too. I'll do a pass and attempt to make the lessons and practices consistent.

NathanLovato commented 2 years ago

Sounds good, we have sprites at least for shield, sword, and whatnot. They should all be in the gunner project, but ping me if you need files

johnnygossdev commented 2 years ago

Got them thanks! I still have them from working with them.

GDQuest / learn-gdscript