search

GDQuest / learn-gdscript

Learn Godot's GDScript programming language from zero, right in your browser, for free.
https://gdquest.github.io/learn-gdscript/
Other
2.11k stars 160 forks source link

Lesson 6 - "Drawing squares of any size" correct solution not accepted #426

Closed MrInventor closed 2 years ago

MrInventor commented 2 years ago

Describe the bug Leaving out the final turn_right(90) will mark the solution as wrong even though the solution seems correct.

To Reproduce Steps to reproduce the bug:

  1. Go to https://gdquest.github.io/learn-gdscript/#course/lesson-6-multiple-function-parameters/practice-v5tT6n1T.tres
  2. func draw_square(length): move_forward(length) turn_right(90) move_forward(length) turn_right(90) move_forward(length) turn_right(90) move_forward(length)

Expected behavior The solution is accepted

Screenshots image

Information about your device (please complete the following information): Windows 10 and Chrome.

NathanLovato commented 2 years ago

Yes, gotta change the practice description, the code doesn't complete the shape as we'd like you to: as the turtle changes direction, it causes subsequent shapes to end up in unintended positions (the second square should be inside the first one). We'll clarify the practice checks and goal.