GDQuest / learn-gdscript

Learn Godot's GDScript programming language from zero, right in your browser, for free.
https://gdquest.github.io/learn-gdscript/
Other
2.11k stars 159 forks source link

Pop-ups links breaks upon loading new page #511

Open Kvazzr opened 2 years ago

Kvazzr commented 2 years ago

Describe the bug Pop-up windows links sometimes breaks upon loading new page. I'm extremely bad at describing. Please see attached screenshot and log.

To Reproduce

  1. Go to select lesson screen
  2. Click on any lesson
  3. It just hapens sometimes

Screenshots 2022-05-03 url

Log gdquest-1651599403349.log

Information about device:

NathanLovato commented 2 years ago

I noticed that before and it's very random, I'm not sure why this is happening. It's even weirder that just reloading the page will typically fix the issue. But thanks for the bug report because we should look into solving this... although we first need to be able to reproduce the issue reliably.

ghost commented 2 years ago

This issue happened to me when I spam clicked "open lesson" on a lesson. My guess is because the page repeatedly loads the text, causing issues when the tags are used repeatedly.

NathanLovato commented 2 years ago

It happens even without spamming, very occasionally. I expect this to be more of a rare failure of the way we use regular expressions or in assigning new text to the lesson content blocks.

ghost commented 2 years ago

It happens even without spamming, very occasionally. I expect this to be more of a rare failure of the way we use regular expressions or in assigning new text to the lesson content blocks.

Oh, I see, thanks.