search

GDQuest / learn-gdscript

Learn Godot's GDScript programming language from zero, right in your browser, for free.
https://gdquest.github.io/learn-gdscript/
Other
2.08k stars 155 forks source link

"Well done" popup appear while the output was generated #62

Closed survivant closed 2 years ago

survivant commented 2 years ago

I was surprise a little. I wrote the code and press RUN. The animation /rectangle was drawing itself and I got a popup while the output was generated. image

Maybe the popup appear as soon as the output is completed, but it's to fast. If it's the case, there should have a little delay after the animation is completed and the popup is shown.

and when the "Well done" appear the animation /output was generated again in the popup, it's normal ?

YuriSizov commented 2 years ago

and when the "Well done" appear the animation /output was generated again in the popup, it's normal ?

It's not generated again. You see them at the same time, because the animation is simply translated from the background into the popup.

generrosity commented 2 years ago

I was definitely caught offguard too. It seemed like there was a momentary pause after clicking 'run', as if the website had stalled! Then the popup immediately appeared.

Is this a 'juice' and 'stealing player focus' suggestion perhaps? I certainly would love to see the animation run, get that juicey output field tickmark bounce / sparkles / border pulse for success, then have the popup? But I can see why getting on with the lesson works too.

xix-xeaon commented 2 years ago

This was a pretty jarring experience. The "well done" needs to happen After the "execution" is completed, even a few hundred milliseconds after the drawing is completed.

YuriSizov commented 2 years ago

You should now be able to see the full execution, then checks passing, and only then have the popup appear.

https://user-images.githubusercontent.com/11782833/149584220-3feb4021-5dd8-4b79-ae45-da637b493212.mp4

This is just one improvement to the practice flow, so stay tuned :) For example, I'll also add animation to the checks soon (https://github.com/GDQuest/learn-gdscript/issues/23), so you'll be able to look at them as well before the popup appears.