GDQuest / learn-gdscript

Learn Godot's GDScript programming language from zero, right in your browser, for free.
https://gdquest.github.io/learn-gdscript/
Other
2.1k stars 155 forks source link

Lesson 14: the flow of the passage about exponential makes it hard to follow #896

Open TaubePigeon opened 10 months ago

TaubePigeon commented 10 months ago

The growth type in one of the examples is not exponential: it is a multiple (multiplier). Or it is simply confusing and unclear to follow, since the explanation is mixing whether or not it multiplies on top of itself for each assignment or using some base status * multiple to reassign altogether.

NathanLovato commented 10 months ago

Is it about this example?

var max_health = 100

func level_up():
    max_health *= 1.1

Or is it another one? Could you please maybe share a screenshot of the example in question?

TaubePigeon commented 10 months ago

I think it's just a little confusing to follow, since you talk about exponential stuff and then talk about multiplication. It might have made more sense to explain multiplication first, and then talk about exponentiation.

image So we have a damage with a level multiplier following the start of your exponential explanation.

image And here, again, the example isn't all that clear, I don't think. It felt like you were going to say something about exponential stuff but ended up not doing that.

image Finally, this image feels like it was supposed to go right after the explanation of exponential stuffs at the start. Though the explanation seems a little unclear about whether or not it is just multiplying by some constant factor, or multiplying + assigning, which would be exponential.

It's not too drastic, but I'm just letting you know that the flow of this passage seems to make it difficult to follow easily, and I'm guessing ease of reading is something you want. It feels like an explanation that gets interrupted by another explanation before finishing the original explanation, which makes for some really broken reading.

NathanLovato commented 10 months ago

You're right, thanks for the detailed breakdown! The lesson overall needs a pass to improve the flow and clarity.