GDQuest / learn-gdscript

Learn Godot's GDScript programming language from zero, right in your browser, for free.
https://gdquest.github.io/learn-gdscript/
Other
2.05k stars 151 forks source link

Lesson 25, inconsistency between add_unit example call arguments and practice exercise place_unit function #981

Open jman904 opened 3 weeks ago

jman904 commented 3 weeks ago

Near the bottom of lesson 25 there is the following code snippet:

1 func run():
2   for cell in unit_cells:
3     var unit = unit_cels[cell]
4     add_unit(unit, cell)

I thought the arg ordering of add_unit was a little strange at first as add_unit(coordinate, unit_name) just feels more intuitive. Sure enough, in the 2nd practice example the order of the args for place_unit is in this order (i.e., place_unit(cell:Vector2, unit_type: String) ). It would probably add clarity to use the same function name, with the same argument ordering, in lesson module associated with the practice.