search

GDS-Education-Community-of-Practice / DSECOP

This repository contains data science educational materials developed by DSECOP Fellows.
Creative Commons Zero v1.0 Universal
43 stars 25 forks source link

Atalla nmr module 1 #9

Closed soltaniehha closed 2 years ago

soltaniehha commented 2 years ago

Hi @swatalla - Great module. A few comments from me:

Please let me know once your changes are complete so I can merge. Thank you!

soltaniehha commented 2 years ago

Hi @swatalla - Great module. A few comments from me:

  • Please move your readme file to the folder. Also, please rename the folder to a name that is distinguishable from other modules (something like "NMR_Spectroscopy_with_Deep_Learning")
  • The notebook looks very good but it's a bit long. Could it be broken up into 2 notebooks? Doesn't have to be before the workshop but something for the future.

Please let me know once your changes are complete so I can merge. Thank you!

@swatalla, can you please double-check? I still see the old file organization