search

GDSC-DSI / Schedura

An Ultimate App to manage your classes in a Smarter Way.
GNU General Public License v3.0
12 stars 8 forks source link

Add edit button to attendance manager. #16

Open debz-g opened 2 years ago

debz-g commented 2 years ago

Please assign this issue to me.

coder2699 commented 2 years ago

@debz-g progress?

debz-g commented 2 years ago

Implementation is done. Some UI changes in the edit menu is left, rest code is ready to push.

debz-g commented 2 years ago

@coder2699 Can you please merge the code from @Keshab0100 that solved Issue #24 so that I can work with updated code.

debz-g commented 2 years ago

The feature is implemented but there is one case regarding updating view model which I am unable to fix @coder2699

debz-g commented 2 years ago

I have two suggestions. First one is a separate issue for adding Shared Preference and second one is another issue for adding Unit tests. @coder2699

debz-g commented 2 years ago

https://drive.google.com/file/d/1MYXBTnD5gPw7Y3srFKGQQiEEcSey4qyt/view?usp=sharing

Check out this video. I edited the classes to 11/20 and click submit, it worked. I edited to 12/20 and clicked outside and the view did not get updated and this is correct.

But after this if we increase from the card the value became 13/21 because it took the value of the edit menu that we did not submit before. @coder2699

debz-g commented 2 years ago

https://bit.ly/schedura-test-app

Try out the app with the code merged to latest main and my edit attendance code. @coder2699

coder2699 commented 2 years ago

I have two suggestions. First one is a separate issue for adding Shared Preference and second one is another issue for adding Unit tests. @coder2699

@debz-g file these issues with appropriate detailed description

coder2699 commented 2 years ago

https://drive.google.com/file/d/1MYXBTnD5gPw7Y3srFKGQQiEEcSey4qyt/view?usp=sharing

Check out this video. I edited the classes to 11/20 and click submit, it worked. I edited to 12/20 and clicked outside and the view did not get updated and this is correct.

But after this if we increase from the card the value became 13/21 because it took the value of the edit menu that we did not submit before. @coder2699

unable to run this video @debz-g