Generic index runnable - Githubissues

GDSC-Delft-Dev / apa

Precision agriculture image processing suite for UAS-acquired multipsectral imagery on GCP

MIT License

4 stars 0 forks source link

Generic index runnable #108

Closed paulmis closed 1 year ago

paulmis commented 1 year ago

Implemented the generic index runnable. It reduces code duplication when implementing further indices (e.g. #80). Unfortunately, I don't think the to_persist is working (for cloud mode runs), so I commented it out for now. Can you check @mirceatlx?

TODO:

fix bulk Mat::get() and add tests

Closes #88

mirceatlx commented 1 year ago

You did not change the nutrient index with the new additions. @paulmis

paulmis commented 1 year ago

The nutrient index isn't abstractable by GenericIndex because it works with masks and patches that the GenericIndex doesn't support. The GenericIndex::calculate() only takes in the input image rather than any segmentation data.

mirceatlx commented 1 year ago

I changed the structure of the Nutrient index such that it can inherit Generic Index. @paulmis take a look