Issue #54 Creating Dialogue Box is fixed

GDSC-PHCET / gdsc-android-app

Community App of Google Developer Student Club @ PHCET

https://play.google.com/store/apps/details?id=com.finite.gdscphcet

13 stars 28 forks source link

Issue #54 Creating Dialogue Box is fixed #61

Closed Vrushali-anil-Chaudhari closed 2 years ago

Vrushali-anil-Chaudhari commented 2 years ago

https://user-images.githubusercontent.com/91819492/161275288-3a2850bf-7e29-4466-9066-6fdd96d3fbfe.mp4

Demo Video

fin1te commented 2 years ago

Hey @Vrushali-anil-Chaudhari, thanks for contributing to this project! :D

The idea is good, but try to fix these two issues with this PR :

the design inside the dialog box can be made better, try out making a more minimal UI
this PR is now 1 commit behind the upstream, update your local origin whenever you make a new PR

fin1te commented 2 years ago

Closing this issue, for now, I would suggest showing your UI design on discord before making a PR so we can discuss and make the PR when the design is finalised.

Let me know if you get confused / need any help!