GDSC-SIT-2024 / HacktoberFest-Session24

4 stars 38 forks source link

Update index.html #8

Open da-ksh-esh opened 1 month ago

da-ksh-esh commented 1 month ago

Identified Issues:

Missing closing tags: In the .back section of the .flip div, there are incomplete or missing closing tags, which will cause rendering issues.

Repetitive SVG elements: The same SVG logo is repeated twice. This creates unnecessary duplication and can be extracted for reuse.

Semantic HTML issues: The is invalid. The correct type should be number for input fields. Missing name attributes for form inputs, which are needed for proper form submission.

Accessibility issues: Inputs lack proper aria-labels or for attributes, making the form less accessible.

Form field validation: No client-side validation is implemented (e.g., for the card number and expiration date).

Year selection options: The expiration year options are outdated (e.g., from 2016–2025), making the form less practical for current use.

Redundant CSS styling inside SVG: The style="enable-background:new 0 0 47.834 47.834;" inside the SVG tag is not necessary in this context.

Non-semantic button content: Instead of using an icon , a more meaningful text or additional labeling should be added to improve accessibility.

Soyvor commented 1 month ago

Ok solve the issue and move forward with them