search

GDSC-UPES / GDSC-UPES-Website

MIT License
16 stars 26 forks source link

added a component #27

Closed lokesh-wagh closed 1 year ago

lokesh-wagh commented 1 year ago

Created a EventDetailHeroComponent that can render the eventDetailHero section

Props need to be passed to the component

netlify[bot] commented 1 year ago

Deploy Preview for upes-gdsc ready!

Name Link
Latest commit e3e3e8a88d1d65becb02e7df8a1c07bcb7d1e061
Latest deploy log https://app.netlify.com/sites/upes-gdsc/deploys/651fe274abaf8300082114a8
Deploy Preview https://deploy-preview-27--upes-gdsc.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

rohin079 commented 1 year ago

Hi @lokesh-wagh I took a look at your PR, great work! However there are some changes that needs to be implemented before i can close this PR as completed:

  1. Replace the current fonts from the used fonts from Figma file ( attached in README file)
  2. Remove the unnecessary text from the hero section
  3. Try adding media query to make the section responsive for mobile devices as well

After implementing these changes, kindly make a PR for Development branch not main. Thanks

lokesh-wagh commented 1 year ago

Ok i will make the changes

lokesh-wagh commented 1 year ago

Hey!!

How does the responsive design need to be any figma for that or same as the desktop figma with same size

akshit-g commented 1 year ago

Hey!!

How does the responsive design need to be any figma for that or same as the desktop figma with same size

We're using the same Figma file, but you just need to adapt it for mobile devices.