search

GDSC-UPES / GDSC-UPES-Website

MIT License
16 stars 26 forks source link

Fixed all the build issues and added the past events and partners page #33

Open AshiqNoor-S opened 1 year ago

AshiqNoor-S commented 1 year ago

@rohin079 I have fixed the issues related to build

I have run the build command locally and it is successful, attached below is a screenshot for your reference

ss

netlify[bot] commented 1 year ago

Deploy Preview for upes-gdsc ready!

Name Link
Latest commit 1bd6707d7d54512be325ff80e0d9207119e7bb48
Latest deploy log https://app.netlify.com/sites/upes-gdsc/deploys/652f95279d027300085f0330
Deploy Preview https://deploy-preview-33--upes-gdsc.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse		 1 paths audited
Performance: 100
Accessibility: 84
Best Practices: 100
SEO: 92
PWA: 70
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

rohin079 commented 1 year ago

@AshiqNoor-S Kindly look at the build preview logs to find out why the build is failing, correct it and then try to raise another commit until all checks are passed

rohin079 commented 1 year ago

@AshiqNoor-S Kindly delete these lines of code since they aren't used and commit again: image

AshiqNoor-S commented 1 year ago

@AshiqNoor-S Kindly delete these lines of code since they aren't used and commit again: image

Done

rohin079 commented 12 months ago

@AshiqNoor-S Hey, the build deploy is still failing, please view the build logs and view why the PR is failing and commit again. Thanks

AshiqNoor-S commented 12 months ago

@rohin079 okay

AshiqNoor-S commented 12 months ago

@rohin079 I actually went through the code, I cant find anything wrong image I also tried building it locally and I am not getting any error

rohin079 commented 11 months ago

@AshiqNoor-S As i can see in your shared screenshot, you have warnings by eslint while trying to build the code, the build checks may also fail due to these warning, Try fixing them such as removing the completed and setcompleted identifier. Also the build log says you have conflicting files like app.jsx and Event.jsx, try to resolve the conflict and commit again.

AshiqNoor-S commented 11 months ago

@rohin079 I have removed all the used states and variables image The build now shows no warnings