GDevelopApp / GDevelop-examples

Repository of examples and templates for GDevelop - the open-source, no-code game engine
https://gdevelop.io
54 stars 20 forks source link

New example: Fixed Camera Transitions [Using Tweens] #149

Closed Elairyx7301 closed 3 years ago

Elairyx7301 commented 3 years ago

Describe the example

This example showcases fixed screen transition. Whenever the player moves outside of the current frame, the camera smoothly moves one room in that direction. A rather easy but sweet event prevents the player from leaving the scene when a transition is happening. Even though this might be most suitable for a Top-Down game, this example shows that it can also find application with other game styles as well. This is just a template and can be modified freely to fit the personal needs or match the game's style and/or atmosphere.

Checklist

Game folder

FixedMoveTransitions.zip image

Midhil457 commented 3 years ago

Hi, here is my short review,

:)

Elairyx7301 commented 3 years ago

@Midhil457 Thank you for that big review!

For me, the project is running smoothly and is at a constant 58 to 60 fps without any lags. I've added a fps counter, maybe you can check with that again. I have noticed the "Top-Down Adventure Camera" example but the main differences are that this is a platformer project using Tweens instead of the lerp() expression method.

Done changes

Version 0.3

v0.1: See original issue v0.2: Never publicly released v0.3: FixedScreenTransition0.3.zip

Please ping me here or on Discord if there are other needed changes to make etc. :)

Midhil457 commented 3 years ago
Elairyx7301 commented 3 years ago

Thank you @Midhil457 again for the review! I have made the changes you recommended.

so that the value doesn't change quickly making it unreadable

Understandable. That's why I had used a timer in the first place. -> Changed anyway

Make the version number 1.0.0 and no don't increment it after every change

That is my understanding of it as well and I prefer that method but I've been "told" (rather shown) differently in other issues and submissions, that's why I adapted to that format in this submission as well. -> Changed to 1.0.0

v1.0.0 - Done changes

Files

FixedScreenTransition1.0.0.zip

Midhil457 commented 3 years ago

Your zip only contains the json file. PLease include the whole project for easy review :)

Elairyx7301 commented 3 years ago

Very sorry for all the bad mistakes and caused inconveniences (as usual) 😅 FixedScreenTransition.zip

Midhil457 commented 3 years ago

Thank you for your contributon! A PR has been created and will be merged (if everything goes well) soon.

I have changed the example's name to Platformer Room Cameraso that users can easily figure out what the example does. Hope you don't mind :)

Elairyx7301 commented 3 years ago

Thank you for the reviewing effort and for opening the PR!